On 03/03/17 14:32, Maxime Ripard wrote: > If we depend on the ARCH_SUNXI configuration option, the boards that do not > have NAND support enabled (with the associated options) will not compile > anymore. > > Depend on the NAND driver configuration option to make sure that is not the > case.
> Reported-by: Chen-Yu Tsai <w...@csie.org> > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> As I came up with an identical patch today to fix sunxi/master: Reviewed-by: Andre Przywara <andre.przyw...@arm.com> So this situation is a bit unfortunate: The sunxi/master branch was updated apparently before even compile-testing it for more than one sunxi board (it is broken for every sunxi board except Chip Pro at the moment: buildman says 105/106). And even after reports and the corresponding fixes appeared (thanks Chen-Yu and Maxime!) the branch is _still_ broken as of today (10 days after the fix was posted). So can we please have both a) a better quality assurance before merging patches into this custodian branch and b) quicker merging of fixes? To my understanding u-boot-sunxi should be always a good and working candidate for anyone interested in Allwinner boards. For a) it would already help to just simply build test sunxi: $ tools/buildman/buildman sunxi but probably extend this to cover at least all ARM boards. Cheers, Andre > --- > cmd/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 585a00c31f4e..91e3d6a46769 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -438,7 +438,7 @@ config CMD_MMC > > config CMD_NAND > bool "nand" > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > NAND support. > > @@ -847,7 +847,7 @@ config CMD_UBI > tristate "Enable UBI - Unsorted block images commands" > select CRC32 > select MTD_UBI > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > UBI is a software layer above MTD layer which admits use of LVM-like > logical volumes on top of MTD devices, hides some complexities of > @@ -862,7 +862,7 @@ config CMD_UBIFS > select CRC32 > select RBTREE if ARCH_SUNXI > select LZO if ARCH_SUNXI > - default y if ARCH_SUNXI > + default y if NAND_SUNXI > help > UBIFS is a file system for flash devices which works on top of UBI. > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
