Hi, On 14 March 2017 at 16:13, Liviu Dudau <li...@dudau.co.uk> wrote: > On Tue, Mar 14, 2017 at 01:54:41PM -0600, Simon Glass wrote: >> From: Eddie Cai <eddie.cai.li...@gmail.com> >> >> use spl_early_init to avoid malloc_base, limit, ptr not initualized. >> >> Signed-off-by: Eddie Cai <eddie.cai.li...@gmail.com> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> >> Changes in v2: >> - Add v2 to the series since this is a new version > > Hi Simon, > > If you are doing this and spending the time to respin, can I suggest > that you improve the readability of this commit message and > s/initualized/initialized/ as a spell fix? > > Also, now that I'm bikeshedding: the first commit message in the > series makes reference to "below patch" and one needs to read the > Fixes line to figure out which patch is referred. Linux kernel's > convention is to name the patch's sha1 directly.
OK I'll tidy these two commit messages up a little more. > > I'm trying to boot Firefly RK3288 Plus with v2017.03 without success. > I've applied this series and it made no difference. I have also > removed CONFIG_SPL_OF_PLATDATA from firefly-rk3288_defconfig (otherwise > doc/README.rockchip makes no sense because there is no spl/u-boot-spl-dtb.bin > and spl/u-boot-spl.bin is the same as spl/u-boot-spl-nodtb.bin), without > any success. > > So, for what is worth, you can also add my Tested-by: Liviu Dudau > <li...@dudau.co.uk> For my testing I enable CONFIG_SPL_OF_PLATDATA and disable CONFIG_ROCKCHIP_SPL_BACK_TO_BROM. How are you creating the SD card (or whatever you boot from)? Regards, Simon > > Best regards, > Liviu > >> >> arch/arm/mach-rockchip/rk3288-board-spl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-rockchip/rk3288-board-spl.c >> b/arch/arm/mach-rockchip/rk3288-board-spl.c >> index e51e19bb2d..f494843663 100644 >> --- a/arch/arm/mach-rockchip/rk3288-board-spl.c >> +++ b/arch/arm/mach-rockchip/rk3288-board-spl.c >> @@ -185,7 +185,7 @@ void board_init_f(ulong dummy) >> debug_uart_init(); >> #endif >> >> - ret = spl_init(); >> + ret = spl_early_init(); >> if (ret) { >> debug("spl_init() failed: %d\n", ret); >> hang(); >> -- >> 2.12.0.367.g23dc2f6d3c-goog >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> https://lists.denx.de/listinfo/u-boot > > -- > _ > _|_|_ > ('_') > (⊃ )⊃ > |_|_| _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot