Hi Maxim, On 21 March 2017 at 17:44, Maxim Sloyko <max...@google.com> wrote: > Hi Joe, > > Please see responses inline, simply ACK'ed comments will be addressed > in the next version. > > On Tue, Mar 21, 2017 at 12:32 PM, Joe Hershberger > <joe.hershber...@gmail.com> wrote: >> On Thu, Mar 16, 2017 at 4:36 PM, Maxim Sloyko <max...@google.com> wrote: >>> The device that Aspeed uses is basically Faraday FTGMAC100, but with >>> some differences here and there. Since I don't have access to a properly >>> implemented FTGMAC100 though, I can't really test it and so I don't >>> feel comfortable claiming compatibility, even though I reused a lot of >>> FTGMAC100 driver code. >> >> I think it would be better to attempt to integrate this driver with >> the FTGMAC driver and ask others on the list who have that HW to test >> your changes to ensure no regressions. I prefer we have fewer drivers >> to maintain. > > One concern: this driver also performs its clock configuration, which > I believe is very specific to the SoC, so to have that compatibility > clock configuration needs to be externalized somehow. I don't know > what is the best way to do it.
Generally the clock is defined by a DT property in the node, so this should work out OK. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot