On 02/25/2017 04:38 PM, yuan linyu wrote:
> From: yuan linyu <linyu.y...@alcatel-sbell.com.cn>
>
> some system will not generate pbl format u-boot, but require rcw.
>
> Signed-off-by: yuan linyu <linyu.y...@alcatel-sbell.com.cn>
> ---
>  tools/pblimage.c | 48 +++++++++++++++++++++++++++---------------------
>  1 file changed, 27 insertions(+), 21 deletions(-)
>
> diff --git a/tools/pblimage.c b/tools/pblimage.c
> index 16d94c98c6..30055a9463 100644
> --- a/tools/pblimage.c
> +++ b/tools/pblimage.c

<snip>

> -             exit(EXIT_FAILURE);
> -     }
> +             if (fstat(fd, &st) == -1) {
> +                     printf("Error: Could not determine u-boot image size. 
> %s\n",
> +                                strerror(errno));

Alignment mismatch.

> +                     exit(EXIT_FAILURE);
> +             }
>
> -     /* For the variable size, we need to pad it to 64 byte boundary */
> -     uboot_size = roundup(st.st_size, 64);
> +             /* For the variable size, we need to pad it to 64 byte boundary 
> */

Line too long.

> +             uboot_size = roundup(st.st_size, 64);
> +             fclose(fp_uboot);
> +     }
>
>       if (params->arch == IH_ARCH_ARM) {
>               arch_flag = IH_ARCH_ARM;
>

Only minor cosmetic issues. I will fix them for you this time if no 
issue found during further testing.

York
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to