On 03/27/2017 01:59 PM, yuiko.osh...@microchip.com wrote: > From: Yuiko Oshino <yuiko.osh...@microchip.com> >> -----Original Message----- >> From: Marek Vasut [mailto:ma...@denx.de] >> Sent: Friday, March 24, 2017 2:29 PM >> To: Yuiko Oshino - C18177; u-boot@lists.denx.de >> Subject: Re: [PATCH v2] Add support for Microchip LAN78xx >> >> On 03/24/2017 07:25 PM, yuiko.osh...@microchip.com wrote: >>> From: Yuiko Oshino <yuiko.osh...@microchip.com> >>>> -----Original Message----- >>>> From: Marek Vasut [mailto:ma...@denx.de] >>>> Sent: Friday, March 10, 2017 2:19 PM >>>> To: Yuiko Oshino - C18177; u-boot@lists.denx.de >>>> Subject: Re: [PATCH v2] Add support for Microchip LAN78xx >>>> >>>> On 03/10/2017 07:38 PM, yuiko.osh...@microchip.com wrote: >>>>> From: Yuiko Oshino <yuiko.osh...@microchip.com> >>>>> >>>>> Add support for Microchip LAN7800 and 7850, USB to 10/100/1000 >>>>> Ethernet Controllers >>>>> >>>>> Signed-off-by: Yuiko Oshino <yuiko.osh...@microchip.com> >>>>> Cc: Marek Vasut <ma...@denx.de> >>>>> --- >>>>> Changes for v2: >>>>> - lan78xx.c header comment cleanup >>>>> >>> >>> [...] >>> >>>> >>>> Why does a lot of this stuff look like the SMSC95xx driver ? >>>> Do we even need a separate driver or can the SMSC95xx driver be >>>> updated to support the LAN78xx ? >>>> >>> >>> Marek, >>> Thank you so much for your review. >>> The LAN78xx's register addresses and bit definitions are not compatible to >> our old part LAN95xx (==SMSC95xx). >>> The new devices LAN78xx and LAN75xx device have similarities. I plan to >> support these two devices in this driver. >>> I will take care of all your comments and will submit a new PATCH with a >>> file >> name change to lan7x.c. >>> >> >> Is the rename really mandatory ? >> > Yes, if we are going to make one file that supports both LAN78xx and LAN75xx, > it's very important for us to make the driver file name to support both > devices.
The filename has nothing to do with which chips are supported though ? >> Then again, I looked into Linux and that one has two separate drivers . >> So I wonder if it's really a good idea. Maybe we can share some common code >> and have the rest separate ? > > Marek, > 1. we can submit LAN78xx and LA75xx drivers separately like in Linux. We do > prefer this option. > 2. we can submit one LAN7x.c that supports both LAN78xx and LAN75xx in one > file. > Could you pick one? Can we have option 3 -- pull common code into some file and make both drivers use the common code ? > Thank you. > Yuiko > >> >> -- >> Best regards, >> Marek Vasut -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
