Hello Adam,
Am 09.04.2017 um 04:29 schrieb Adam Ford:
On Sat, Apr 8, 2017 at 5:53 PM, Tom Rini <tr...@konsulko.com> wrote:
On Sat, Apr 08, 2017 at 05:34:29PM -0500, Adam Ford wrote:
The register names and offset were not correct as per the TRM for OMAP3530
and OMAP3630. Correct the naing and offsets per the documentation
Signed-off-by: Adam Ford <aford...@gmail.com>
diff --git a/arch/arm/include/asm/arch-omap3/i2c.h
b/arch/arm/include/asm/arch-omap3/i2c.h
index b370290..6b3a3da 100644
--- a/arch/arm/include/asm/arch-omap3/i2c.h
+++ b/arch/arm/include/asm/arch-omap3/i2c.h
@@ -17,7 +17,7 @@ struct i2c {
unsigned short res2;
unsigned short stat; /* 0x08 */
unsigned short res3;
- unsigned short iv; /* 0x0C */
+ unsigned short we; /* 0x0C */
unsigned short res4;
unsigned short syss; /* 0x10 */
unsigned short res4a;
@@ -43,6 +43,18 @@ struct i2c {
unsigned short res14;
unsigned short systest; /* 0x3c */
unsigned short res15;
+ unsigned short bufstat; /* 0x40 */
+ unsigned short res16;
+ unsigned short oa1; /* 0x44 */
+ unsigned short res17;
+ unsigned short oa2; /* 0x48 */
+ unsigned short res18;
+ unsigned short oa3; /* 0x4c */
+ unsigned short res19;
+ unsigned short actoa; /* 0x50 */
+ unsigned short res20;
+ unsigned short sblock; /* 0x54 */
+ unsigned short res21;
};
Are we making use of any of these new entries?
Not really. I am trying to get DM_I2C working on OMAP3 and I was
looking through the history of what was done to make it work on AM33xx
and OMAP4+. Commit 3465f807d4b90378d86b3 ("omap4: i2c: correct
register offset for sync register") corrected some incorrect
registers, so I thought I'd look through the corresponding file for
omap3. I noticed that offset 0x0C was not named right per the TRM, so
I read through to the rest. I can see the argument for not pulling in
the new stuff, but I was trying to be consistent with what was done
for omap4 and omap5.
I like to have this corrected version, so:
Reviewed-by: Heiko Schocher <h...@denx.de>
but last OK should come from Tom, thanks!
bye,
Heiko
adam
--
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
