On Tuesday 25 April 2017 01:26 PM, Heiko Schocher wrote: > Hello Lokesh, > > Am 25.04.2017 um 05:03 schrieb Lokesh Vutla: >> Hi Simon, >> >> On Sunday 23 April 2017 09:05 PM, Simon Glass wrote: >>> Drop use of this long-deprecated option. >>> >>> Signed-off-by: Simon Glass <s...@chromium.org> >>> --- >>> >>> README | 16 ++++++++-------- >>> board/ti/am335x/board.c | 6 +----- >>> board/ti/am43xx/board.c | 3 +-- >> >> [..snip..] >> >>> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c >>> index 3e842d3187..0d2e84011d 100644 >>> --- a/board/ti/am335x/board.c >>> +++ b/board/ti/am335x/board.c >>> @@ -67,11 +67,7 @@ static struct ctrl_dev *cdev = (struct ctrl_dev >>> *)CTRL_DEVICE_BASE; >>> #ifdef CONFIG_TI_I2C_BOARD_DETECT >>> void do_board_detect(void) >>> { >>> - enable_i2c0_pin_mux(); >>> - i2c_init(CONFIG_SYS_OMAP24_I2C_SPEED, CONFIG_SYS_OMAP24_I2C_SLAVE); >>> - >>> - if (ti_i2c_eeprom_am_get(-1, CONFIG_SYS_I2C_EEPROM_ADDR)) >> >> This is very early board detection code that happens in SPL. There were >> common Kconfig options added for eeprom >> address(CONFIG_EEPROM_BUS_ADDRESS, CONFIG_EEPROM_CHIP_ADDRESS) but >> missed updating in these boards. >> >> Instead of removing can this be updated to >> >> - if (ti_i2c_eeprom_am_get(-1, CONFIG_SYS_I2C_EEPROM_ADDR)) >> + if (ti_i2c_eeprom_am_get(CONFIG_EEPROM_BUS_ADDRESS, >> + CONFIG_EEPROM_CHIP_ADDRESS)) >> printf("ti_i2c_eeprom_init failed\n"); >> } >> #endif > > Good catch. Do you have time for testing Simons patchseries > on a real hw?
Yeah, this series breaks booting of BeagleBone Black. The above mentioned diff fixes it. Thanks and regards, Lokesh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot