Dear Wolfgang Wegner, In message <1256914121-26044-1-git-send-email-w.weg...@astro-kom.de> you wrote: > write_buff_nb() introduces quite an amount of duplicate code compared to > write_buff(), but I did not find an elegant solution to partition them. > > Signed-off-by: Wolfgang Wegner <w.weg...@astro-kom.de> > --- > drivers/mtd/cfi_flash.c | 440 > ++++++++++++++++++++++++++++++++++++++--------- > include/flash.h | 3 + > 2 files changed, 365 insertions(+), 78 deletions(-)
This summary alone is a pretty clear message to me. This is indeed a lot of added, and even worse, duplicated code. I see currently no reason to change my mind: I don;t want to see this code in mainline. It breaks with the design principles, and makes the common code more difficult to maintain with no benefit for the majority of the users. Sorry. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de But it's real. And if it's real it can be affected ... we may not be able to break it, but, I'll bet you credits to Navy Beans we can put a dent in it. -- deSalle, "Catspaw", stardate 3018.2 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot