Hi Peng, On 25 April 2017 at 14:51, Peng Fan <peng....@nxp.com> wrote: > Hi Simon, > >> -----Original Message----- >> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass >> Sent: Monday, April 24, 2017 11:38 AM >> To: Peng Fan <peng....@nxp.com> >> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Tom Rini >> <tr...@konsulko.com>; Eddie Cai <eddie.cai.li...@gmail.com>; Jagan Teki >> <jt...@openedev.com>; york sun <york....@nxp.com>; Robert P. J. Day >> <rpj...@crashcourse.ca>; Michal Simek <michal.si...@xilinx.com> >> Subject: Re: [PATCH 2/2] asm-generic: global_data: change timebase_l/h to >> unsigned int >> >> Hi Peng, >> >> On 19 April 2017 at 19:10, Peng Fan <peng....@nxp.com> wrote: >> > Change type of timebase_l/h to unsigned int. >> >> What is the motivation for this, please? > > From lib/time.c: ((uint64_t)gd->timebase_h << 32) | gd->timebase_l; > > This piece code is based on that timebase_h and timebase_l are 32bits width, > I think. > But unsigned long are 64bits width on ARM64. I am not sure, but I suppose > same case > on other archs.
OK I see. I suspect it would make more sense to have a single 64-bit value on 64-bit machines, but perhaps that is a separate point. Reviewed-by: Simon Glass <s...@chromium.org> > > Thanks, > Peng. > >> >> > >> > Signed-off-by: Peng Fan <peng....@nxp.com> >> > Cc: Simon Glass <s...@chromium.org> >> > Cc: Eddie Cai <eddie.cai.li...@gmail.com> >> > Cc: Jagan Teki <jt...@openedev.com> >> > Cc: York Sun <york....@nxp.com> >> > Cc: "Robert P. J. Day" <rpj...@crashcourse.ca> >> > Cc: Michal Simek <michal.si...@xilinx.com> >> > Cc: Tom Rini <tr...@konsulko.com> >> > --- >> > >> > Buildman shows the following build failure, but not related this patch. >> > aarch64: + orangepi_pc2 >> > x86: + qemu-x86_64 qemu-x86_efi_payload64 chromebook_link64 >> > >> > include/asm-generic/global_data.h | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> >> Regards, >> Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
