On 05/09/2017 02:16 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard <patrice.chot...@st.com> > > This is the generic phy driver for the picoPHY ports > used by USB2/1.1 controllers. It is found on STiH407 SoC > family from STMicroelectronics. > > Signed-off-by: Patrice Chotard <patrice.chot...@st.com> > --- > > v4: _ update to use the new PHY uclass currently available on dm-next branch > > v3: _ convert driver to USB PHY uclass > > v2: _ replace bitfield_replace() by clrsetbits_le32() > > doc/device-tree-bindings/phy/phy-stih407-usb.txt | 24 +++ > drivers/phy/Kconfig | 8 + > drivers/phy/Makefile | 1 + > drivers/phy/sti_usb_phy.c | 181 > +++++++++++++++++++++++ > 4 files changed, 214 insertions(+) > create mode 100644 doc/device-tree-bindings/phy/phy-stih407-usb.txt > create mode 100644 drivers/phy/sti_usb_phy.c > > diff --git a/doc/device-tree-bindings/phy/phy-stih407-usb.txt > b/doc/device-tree-bindings/phy/phy-stih407-usb.txt > new file mode 100644 > index 0000000..de6a706 > --- /dev/null > +++ b/doc/device-tree-bindings/phy/phy-stih407-usb.txt > @@ -0,0 +1,24 @@ > +ST STiH407 USB PHY controller > + > +This file documents the dt bindings for the usb picoPHY driver which is the > PHY for both USB2 and USB3 > +host controllers (when controlling usb2/1.1 devices) available on STiH407 > SoC family from STMicroelectronics. > + > +Required properties: > +- compatible : should be "st,stih407-usb2-phy" > +- st,syscfg : phandle of sysconfig bank plus integer array > containing phyparam and phyctrl register offsets > +- resets : list of phandle and reset specifier pairs. There > should be two entries, one > + for the whole phy and one for the port > +- reset-names : list of reset signal names. Should be > "global" and "port" > +See: Documentation/devicetree/bindings/reset/st,sti-powerdown.txt > +See: Documentation/devicetree/bindings/reset/reset.txt > + > +Example: > + > +usb2_picophy0: usbpicophy@f8 { > + compatible = "st,stih407-usb2-phy"; > + #phy-cells = <0>; > + st,syscfg = <&syscfg_core 0x100 0xf4>; > + resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > + <&picophyreset STIH407_PICOPHY0_RESET>; > + reset-names = "global", "port"; > +};
Is this imported from Linux ? Otherwise looks ok, Reviewed-by: Marek Vasut <ma...@denx.de> -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot