On 05/17/2017 04:55 PM, Uri Mashiach wrote:
> Modifications:
> * The call condition of the function net_process_received_packet() is
> the success of the function mcs7830_recv_common().
> * The return value of the function mcs7830_recv reflects the success of
> the function mcs7830_recv_common().
Can you rewrite the commit message such that it's clear what you're
doing here ? The mcs7830_recv_common() probably returns negative on
error, 0 or positive on success, right ?
> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il>
> ---
> drivers/usb/eth/mcs7830.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/eth/mcs7830.c b/drivers/usb/eth/mcs7830.c
> index 9d6cf8c..4abef5d 100644
> --- a/drivers/usb/eth/mcs7830.c
> +++ b/drivers/usb/eth/mcs7830.c
> @@ -622,10 +622,12 @@ static int mcs7830_recv(struct eth_device *eth)
> int len;
>
> len = mcs7830_recv_common(ueth, buf);
> - if (len <= 0)
> + if (len >= 0) {
> net_process_received_packet(buf, len);
> + return 0;
> + }
>
> - return 0;
> + return len;
> }
>
> /*
>
--
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
