Dear Tom Rix, In message <1257292804-10612-2-git-send-email-tom....@windriver.com> you wrote: > The ARM board LED functions are defined as weak. > They add a size overhead if they are not used. > > Now they are only defined if CONFIG_STATUS_LED is also defined. > > The arm920t and arm926ejs _start function calls these LED functions > > bl coloured_LED_init > bl red_LED_on > > In general, what happens is they call into the weak > stubs. Only if the cpu/board provides an overriding > function do these calls cause anything meaningful to > happen. > > Now this noop case is removed and these LED functions are excuted > only when CONFIG_STATUS_LED is defined
I don't get it. We use "weak" to avoid #ifdef's, and you insert new #ifdef's? That seems to be the wrong approach to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "What if" is a trademark of Hewlett Packard, so stop using it in your sentences without permission, or risk being sued. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
