On Wed, Nov 04, 2009 at 10:39:41AM +0530, Amul Kumar Saha wrote:
> while (blocks) {
> + blocksize = onenand_blocksize(ofs);
> +
> ret = mtd->block_isbad(mtd, ofs);
> if (ret) {
> printk("Bad blocks %d at 0x%x\n",
> - (u32)(ofs >> this->erase_shift), (u32)ofs);
> + (u32)onenand_block(this, ofs), (u32)ofs);
This isn't new, but %d doesn't match u32 (though I guess GCC doesn't
complain about signedness) -- and we shouldn't be chopping off the upper
bits of ofs.
> + blocks = (int) onenand_block(this, ofs + len)
> + - onenand_block(this, ofs);
Unnecessary cast.
> @@ -493,9 +531,11 @@ U_BOOT_CMD(
> "onenand write[.oob] addr off size\n"
> " read/write 'size' bytes starting at offset 'off'\n"
> " to/from memory address 'addr', skipping bad blocks.\n"
> - "onenand erase [force] [off size] - erase 'size' bytes from\n"
> + "onenand erase [force] [off size] - erase 'size' bytes from off\n"
> "onenand test [off size] - test 'size' bytes from\n"
> " offset 'off' (entire device if not specified)\n"
> "onenand dump[.oob] off - dump page\n"
> "onenand markbad off [...] - mark bad block(s) at offset (UNSAFE)"
> + "onenand setboundary DIE BOUNDARY [LOCK] - \n"
> + "Change SLC boundary of Flex-OneNAND\n"
Description should be indented if you're going to put it on a new line.
-Scott
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
