On Sat, May 20, 2017 at 07:27:53PM -0700, ali...@peloton-tech.com wrote:

> From: Alison Chaiken <ali...@she-devel.com>
> 
> In order to read the GPT, modify the partition name strings, and then
> write out a new GPT, the disk GUID is needed.  While there is an
> existing accessor for the partition UUIDs, there is none yet for the
> disk GUID.
> 
> Signed-off-by: Alison Chaiken <ali...@peloton-tech.com>

Overall looks good, a few style things:

> +     if (namestr != NULL)
> +             setenv(namestr, disk_guid);

You can just if (namestr) here

[snip]
> +     } else if (strcmp(argv[1], "guid") == 0) {
> +             if (argc == 5) strcpy(varname, argv[4]);

Go ahead and do this on multiple lines please.  Thanks!

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to