On Tuesday 13 June 2017 09:04 AM, Keerthy wrote: > > > On Tuesday 13 June 2017 05:21 AM, Simon Glass wrote: >> On 10 June 2017 at 23:01, Keerthy <j-keer...@ti.com> wrote: >>> The function wrongly returned an integer while it is supposed to >>> return boolean. Fix that. >>> >>> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") >>> Signed-off-by: Keerthy <j-keer...@ti.com> >>> --- >>> drivers/power/regulator/lp873x_regulator.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> >> I think in fact we should return int from this method in struct >> dm_regulator_ops. I don't really like not being able to return an >> error. >> >> So bonus points if you can change that :-)
Simon, https://lists.denx.de/pipermail/u-boot/2017-June/295326.html For changing the return type. Regards, Keerthy > > I did not touch it as it was being used at many places. Seems like that > is the right thing to do. I believe this series can be discarded. I will > post a series where in all are changed to return int. > > >> > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot