Dear "Hui.Tang",
In message <1257324383-19408-1-git-send-email-zetal...@gmail.com> you wrote:
> Add ARM920T NAND flash booting.
>
> checkpatch.pl shows that all things are fine.
>
> total: 0 errors, 0 warnings, 70 lines checked
>
> 0002-ARM920T-NAND-flash-booting.patch has no obvious style problems and is
> ready for submission.
>
> =========================================================
> Signed-off-by: Hui.Tang <zetal...@gmail.com>
> ---
> cpu/arm920t/start.S | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/cpu/arm920t/start.S b/cpu/arm920t/start.S
> index 114427a..9b08e3c 100644
> --- a/cpu/arm920t/start.S
> +++ b/cpu/arm920t/start.S
> @@ -38,6 +38,7 @@
>
> .globl _start
> _start: b start_code
> +#ifndef CONFIG_NAND_SPL
> ldr pc, _undefined_instruction
> ldr pc, _software_interrupt
> ldr pc, _prefetch_abort
> @@ -53,7 +54,13 @@ _data_abort: .word data_abort
> _not_used: .word not_used
> _irq: .word irq
> _fiq: .word fiq
> +_pad: .word 0x12345678 /* now 16*4=64 */
> +#else
> + . = _start + 64
> +#endif
As there is no code added to ever set CONFIG_NAND_SPL, all this is
just dead code - or an incomplete patch.
Please make sure to split your patches such that they are really
orthogonal to each other. Don't add some parts of CONFIG_NAND_SPL
stuff in one patch and some other parts in another one.
> _start_armboot: .word start_armboot
> +#else
> + b nand_boot
> +/* .word nand_boot */
Don't add dead code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The use of COBOL cripples the mind; its teaching should, therefore,
be regarded as a criminal offence.
-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
