Hi, On 04/07/17 11:43, Icenowy Zheng wrote: > The Ethernet function is enabled in the Orange Pi PC2 device tree and > defconfig, however, CONFIG_MACPWR is not properly set, which left the > PHY being disabled when booting, which makes the Ethernet function not > usable.
Indeed, so I can remove this very same patch from my queue here ;-) > Add the proper value of this option in the PC2 defconfig. > > Fixes: e7bd15ea156f ("sunxi: Add OrangePi PC 2 initial support") I believe the support for CONFIG_MACPWR wasn't there when I wrote this patch, so I hacked this into my ATF port at the time ;-) > Signed-off-by: Icenowy Zheng <icen...@aosc.io> Acked-by: Andre Przywara <andre.przyw...@arm.com> Thanks, Andre. > --- > configs/orangepi_pc2_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/orangepi_pc2_defconfig b/configs/orangepi_pc2_defconfig > index 5a64ad3f41..b72514d3b9 100644 > --- a/configs/orangepi_pc2_defconfig > +++ b/configs/orangepi_pc2_defconfig > @@ -4,6 +4,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y > CONFIG_MACH_SUN50I_H5=y > CONFIG_DRAM_CLK=672 > CONFIG_DRAM_ZQ=3881977 > +CONFIG_MACPWR="PD6" > CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2" > # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > CONFIG_SPL=y > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot