Dear Simon,
In message <20170709205313.116174-29-...@chromium.org> you wrote:
> Use the env_save() function directly now that there is only one
> implementation of saveenv().
...
> printf("Setting reboot to fastboot flag ...\n");
> setenv("dofastboot", "1");
> - saveenv();
> + env_save();
Hm... the old name saveenv() was once derived from the command line
command with the same name, in the same way as setenv() is/was.
One can argument that your new name env_save( corresponds to the more
modern "env <subcommand>" syntax - but should we then not also
rename setenv() into env_set() , so we use a consistent naming
scheme again?
Reviewed-by: Wolfgang Denk <w...@denx.de>
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
He'd heard her use that sweet, innocent tone of voice before. It
meant that, pretty soon, there was going to be trouble.
- Terry Pratchett, _Truckers_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
