[U-Boot] [PATCH 44/51] gdsys: cmd_ioloop: Introduce commenting enum

[Mario Six]

Replace the boolean parameter of io_check_status that controls whether
the status is printed or not with a documenting enum.

Signed-off-by: Mario Six <mario....@gdsys.cc>
---

 board/gdsys/common/cmd_ioloop.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/board/gdsys/common/cmd_ioloop.c b/board/gdsys/common/cmd_ioloop.c
index a052b24501..2ea8bc8670 100644
--- a/board/gdsys/common/cmd_ioloop.c
+++ b/board/gdsys/common/cmd_ioloop.c
@@ -11,6 +11,11 @@
 
 #include <gdsys_fpga.h>
 
+enum status_print_type {
+       STATUS_LOUD = 0,
+       STATUS_SILENT = 1,
+};
+
 enum {
        STATE_TX_PACKET_BUILDING = BIT(0),
        STATE_TX_TRANSMITTING = BIT(1),
@@ -53,7 +58,7 @@ unsigned long long rx_ctr;
 unsigned long long tx_ctr;
 unsigned long long err_ctr;
 
-static void io_check_status(uint fpga, u16 status, bool silent)
+static void io_check_status(uint fpga, u16 status, enum status_print_type type)
 {
        u16 mask = STATE_RX_DIST_ERR | STATE_RX_LENGTH_ERR |
                   STATE_RX_FRAME_CTR_ERR | STATE_RX_FCS_ERR |
@@ -67,7 +72,7 @@ static void io_check_status(uint fpga, u16 status, bool 
silent)
        err_ctr++;
        FPGA_SET_REG(fpga, ep.rx_tx_status, status);
 
-       if (silent)
+       if (type == STATUS_SILENT)
                return;
 
        if (status & STATE_RX_PACKET_DROPPED)
@@ -194,7 +199,7 @@ int do_ioreflect(cmd_tbl_t *cmdtp, int flag, int argc, char 
* const argv[])
                FPGA_GET_REG(fpga, top_interrupt, &top_int);
                FPGA_GET_REG(fpga, ep.rx_tx_status, &rx_tx_status);
 
-               io_check_status(fpga, rx_tx_status, true);
+               io_check_status(fpga, rx_tx_status, STATUS_SILENT);
                if ((top_int & IRQ_CPU_RECEIVE_DATA_AVAILABLE_STATUS) &&
                    (top_int & IRQ_CPU_TRANSMITBUFFER_FREE_STATUS))
                        io_reflect(fpga);
@@ -261,7 +266,7 @@ int do_ioloop(cmd_tbl_t *cmdtp, int flag, int argc, char * 
const argv[])
                FPGA_GET_REG(fpga, top_interrupt, &top_int);
                FPGA_GET_REG(fpga, ep.rx_tx_status, &rx_tx_status);
 
-               io_check_status(fpga, rx_tx_status, false);
+               io_check_status(fpga, rx_tx_status, STATUS_LOUD);
                if (top_int & IRQ_CPU_TRANSMITBUFFER_FREE_STATUS)
                        io_send(fpga, size);
                if (top_int & IRQ_CPU_RECEIVE_DATA_AVAILABLE_STATUS)
-- 
2.11.0

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot