On 7/14/2017 6:30 PM, Adam Ford wrote: > On Fri, Jul 14, 2017 at 6:35 AM, Adam Ford <aford...@gmail.com> wrote: >> On Tue, Jul 11, 2017 at 7:40 AM, Tom Rini <tr...@konsulko.com> wrote: >>> On Tue, Jun 27, 2017 at 01:50:56PM +0530, Lokesh Vutla wrote: >>> >>>> ROM stores the boot params information in a known location >>>> and passes it to SPL. This information needs to be copied >>>> very early during boot or else there is a chance of getting >>>> corrupted by SPL. So move this boot device detection very early >>>> during boot. >>>> >>>> Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> >>>> Reviewed-by: Tom Rini <tr...@konsulko.com> >>> >>> Applied to u-boot/master, thanks! >>> >> >> Master no longer boots my DM3730 (omap3_logic). Has anyone else had >> issues with their OMAP3 board? v2017.07 works and the bisect >> revealed: >> >> 4bd754d8abef61835d5da2ba0c65b2b0d3badec9 is the first bad commit >> commit 4bd754d8abef61835d5da2ba0c65b2b0d3badec9 >> Author: Lokesh Vutla <lokeshvu...@ti.com> >> Date: Tue Jun 27 13:50:56 2017 +0530 >> >> arm: omap: Detect boot mode very early >> >> ROM stores the boot params information in a known location >> and passes it to SPL. This information needs to be copied >> very early during boot or else there is a chance of getting >> corrupted by SPL. So move this boot device detection very early >> during boot. >> >> Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> >> Reviewed-by: Tom Rini <tr...@konsulko.com> >> >> :040000 040000 eba151d04f1f62d4acd83b7ba47f627956eab8fb >> b36ef87618be765d9a4986dd9a8b013b357f4611 M arch >> >> >> > > The following patch appears to work, but I would like some feedback > from TI guys. If that seems reasonable, I'll submit a more formal > patch. >
Yeas, this looks good to me. Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh > > diff --git a/arch/arm/mach-omap2/omap3/board.c > b/arch/arm/mach-omap2/omap3/board.c > index cd8e302..f8db543 100644 > --- a/arch/arm/mach-omap2/omap3/board.c > +++ b/arch/arm/mach-omap2/omap3/board.c > @@ -212,6 +212,12 @@ void board_init_f(ulong dummy) > { > early_system_init(); > mem_init(); > + /* > + * Save the boot parameters passed from romcode. > + * We cannot delay the saving further than this, > + * to prevent overwrites. > + */ > + save_omap_boot_params(); > } > #endif > > > >>> -- >>> Tom >>> >>> _______________________________________________ >>> U-Boot mailing list >>> U-Boot@lists.denx.de >>> https://lists.denx.de/listinfo/u-boot >>> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot