Hi Simon, On Tue, Jul 18, 2017 at 4:01 PM, Simon Glass <s...@chromium.org> wrote: > Hi Mario, > > On 14 July 2017 at 05:54, Mario Six <mario....@gdsys.cc> wrote: >> From: Dirk Eibach <dirk.eib...@gdsys.cc> >> >> Implement support for the Marvell Alaska X 88X2242P Integrated Dual-port >> and Quad-port Multi-speed Ethernet Transceivers. >> >> Signed-off-by: Dirk Eibach <dirk.eib...@gdsys.cc> >> Signed-off-by: Mario Six <mario....@gdsys.cc> >> --- >> >> drivers/net/phy/Kconfig | 67 ++++ >> drivers/net/phy/Makefile | 1 + >> drivers/net/phy/marvell.c | 1 - >> drivers/net/phy/mv88x2.c | 846 >> ++++++++++++++++++++++++++++++++++++++++++++++ >> drivers/net/phy/mv88x2.h | 12 + >> drivers/net/phy/phy.c | 3 + >> include/phy.h | 1 + >> 7 files changed, 930 insertions(+), 1 deletion(-) >> create mode 100644 drivers/net/phy/mv88x2.c >> create mode 100644 drivers/net/phy/mv88x2.h >> > > We should really be using driver model here. Is the generic phy uclass > good enough (generic-phy.h), or do we need a new uclass for Ethernet > PHY? >
Wouldn't we also need a uclass for MDIO/MII interfaces then? I don't know the network subsystem too well, so I can't really tell where a ethernet phy uclass (or a MDIO uclass for that matter) would interface with the rest of it. > Regards, > Simon Best regards, Mario _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
