> -----Original Message----- > From: Tom Rini [mailto:tr...@konsulko.com] > Sent: Monday, August 14, 2017 8:04 PM > To: Sumit Garg <sumit.g...@nxp.com> > Cc: u-boot@lists.denx.de; York Sun <york....@nxp.com>; Ruchika Gupta > <ruchika.gu...@nxp.com>; Prabhakar Kushwaha > <prabhakar.kushw...@nxp.com>; s...@chromium.org > Subject: Re: [PATCH] hash: Compile-off SHA SW lib in case SHA HW lib is > present > > On Mon, Aug 14, 2017 at 05:09:46PM +0530, Sumit Garg wrote: > > > Commit 089df18bfe9d ("lib: move hash CONFIG options to Kconfig") moved > > CONFIG_SHA1, CONFIG_SHA256, CONFIG_SHA_HW_ACCEL, and > > CONFIG_SHA_PROG_HW_ACCEL config options to Kconfig. So in case of SPL, > > CONFIG_SPL_HASH_SUPPORT enables CONFIG_SHA1 and CONFIG_SHA256 > which > > enables SHA SW library by default. But in case of platforms with SHA > > HW library support, SHA SW library becomes redundant and increases > > size of SPL by approx 18K. So to take care of this SHA SW library is > > compiled-off in case SHA HW acceleration is present. > > > > Signed-off-by: Sumit Garg <sumit.g...@nxp.com> > > --- > > common/hash.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > Good find. Looking at the code I think this can be done a bit differently to > clean > up the code as well, which was the first thing I was wondering about when > looking this over. I'll have a v2 of this hopefully later today (testing in > travis > now). Thanks! > > -- > Tom Thanks Tom for your comments.
Sumit _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
