Hello,
On Thu, 24 Aug 2017 12:16:30 +0200, Wolfgang Denk wrote:
> > In this patch series, I propose to have U-Boot define some sane
> > defaults for those 4 configuration options, and cleanup all the board
> > configuration files that were using the default values. This leads to
> > the removal of 1300+ lines.
>
> Would it not be even easier (and less code) to move these
> definitions to Kconfig settings?
I believe this patch series is a step in that direction. With this
patch series applied, we can now clearly identify which boards have
custom values for CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE}, and
therefore more easily move these from the .h files to defconfig files.
Unless of course we decide that having such custom values
in .h/defconfig is useless, and we want to drop them entirely. As I
said in my cover letter, I really don't see why a board configuration
file (be it a .h or a defconfig) should specify the maximum number of
command arguments or the maximum size of the Linux kernel command line.
The choice for such values is totally independent from the HW, but
rather tied to the specific use of a given board. For the same board,
most people will find the default value to be OK, some people will need
a larger number of command arguments or a bigger Linux kernel command
line.
Let me know what your preference is.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
