On 08/28/2017 01:02 AM, Chaiken, Alison wrote:
On 2017-05-31 01:12, Lukasz Majewski wrote:
[ . . . ]
And another request -> Could you consider adding tests for those new
gpt commands to the 'sandbox' (sandbox_defconfig) ?
Then you can 'mount' some gpt test image ('host' command) and use it
with:
gpt <command> host X .....
The GPT functionality really cannot be tested without a block device.
We could build the disk.raw described in board/sandbox/README.sandbox
when (CONFIG_UNIT_TEST && CONFIG_CMD_GPT_RENAME) in imitation of the
file helloworld.efi. There would be no reason for the size to be as
large as 1200M, of course. 256KB appears to be the smallest usable
size for 4 partitions (although trying to partition a 16 KB raw object
with gdisk produces entertaining results).
To create this object for testing, we could use a subdirectory like
lib/efi_loader, but maybe doing so in test/ makes more sense? If the
build system did create the object, then we could modify
board/sandbox/README.sandbox to so indicate. Then the test should go
in test/py/tests presumably.
If you have encountered some issues with adding this test to sandbox
(and those are difficult to solve), then it would be also correct to add
this test to test/py and run it on a real HW.
Please also keep in mind to provide some kind of verbose in-code
description or proper documentation entry.
Thanks for feedback,
Alison
---
Alison Chaiken ali...@she-devel.com
http://{ she-devel.com, exerciseforthereader.org }
"We are giving up our privacy, one convenience at a time." -- Evangelos
Simoudis
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
