On 08/30/2017 07:59 AM, Chee, Tien Fong wrote:
> On Sel, 2017-08-29 at 13:51 +0200, Marek Vasut wrote:
>> On 08/29/2017 12:45 PM, tien.fong.c...@intel.com wrote:
>>>
>>> From: Tien Fong Chee <tien.fong.c...@intel.com>
>>>
>>> This config allow FPGA design loaded from FAT fs to FPGA manager.
>>>
>>> Signed-off-by: Tien Fong Chee <tien.fong.c...@intel.com>
>>> ---
>>>  configs/socfpga_arria10_defconfig |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/configs/socfpga_arria10_defconfig
>>> b/configs/socfpga_arria10_defconfig
>>> index 53ab66f..d555743 100644
>>> --- a/configs/socfpga_arria10_defconfig
>>> +++ b/configs/socfpga_arria10_defconfig
>>> @@ -29,3 +29,4 @@ CONFIG_DWAPB_GPIO=y
>>>  CONFIG_DM_MMC=y
>>>  CONFIG_SYS_NS16550=y
>>>  CONFIG_USE_TINY_PRINTF=y
>>> +CONFIG_CMD_FPGA_LOADFS=y
>> You should enable stuff only after you add the necessary support bits
>> ...
>>
> I enabled it as early as possible, because i would like to use
> compiling for detecting any code errors while adding the neccesssary
> support bits. I can rearrange the patches sequence.
> 
Except you enable feature which cannot work, so this is wrong. If you
need this for debugging purposes, great, but in the series it should go
after the groundwork is laid.

-- 
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to