On 08/30/2017 10:12 AM, York Sun wrote: > On 08/26/2017 06:39 AM, Simon Glass wrote: >> On 15 August 2017 at 12:14, York Sun <york....@nxp.com> wrote: >>> SPL supports U-Boot image in FIT format which has data outside of >>> FIT structure. This adds support for embedded data for normal FIT >>> images. >>> >>> Signed-off-by: York Sun <york....@nxp.com> >>> Reviewed-by: Tom Rini <tr...@konsulko.com> >>> >>> --- >>> >>> Changes in v3: >>> Update doc/uImage.FIT/source_file_format.txt with embedded and external data >>> >>> Changes in v2: >>> Rebase on top of "SPL: FIT: factor out spl_load_fit_image()" by Andre >>> Przywara >>> >>> common/spl/spl_fit.c | 52 >>> ++++++++++++++++++++++------------- >>> doc/uImage.FIT/source_file_format.txt | 4 +++ >>> 2 files changed, 37 insertions(+), 19 deletions(-) >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> >> Please see nit below. >> > <snip> > >>> diff --git a/doc/uImage.FIT/source_file_format.txt >>> b/doc/uImage.FIT/source_file_format.txt >>> index 136d3d7..3ce47ed 100644 >>> --- a/doc/uImage.FIT/source_file_format.txt >>> +++ b/doc/uImage.FIT/source_file_format.txt >>> @@ -288,6 +288,10 @@ The 'data-offset' property can be substituted with >>> 'data-position', which >>> defines an absolute position or address as the offset. This is helpful >>> when >>> booting U-Boot proper before performing relocation. >>> >>> +Normal kernel FIT image has data embedded within FIT structure. Normal >>> U-Boot >>> +image has external data. Existence of 'data-offset' can be used to identify >> >> I think actually external data is normal for SPL but not for U-Boot >> proper. I don't know if that is worth mentioning though. >> > > I will change to "U-Boot SPL image has external data" when merging this > patch. >
I should say "U-Boot image for SPL boot has external data". York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot