On 09/01/2017 10:36 AM, Łukasz Majewski wrote: > On 09/01/2017 10:19 AM, Marek Vasut wrote: >> On 08/31/2017 08:20 PM, Sam Protsenko wrote: >>> Since 842778a09104 commit, "fastboot devices" stopped to show correct >>> device serial number for TI boards, showing this line instead: >>> >>> ???????????? fastboot >>> >>> This is because serial# env variable could be set after g_dnl gadget was >>> initialized (e.g. by using env_set() in the board file). >>> >>> To fix this, before checking g_dnl_serial, let's re-check if we have >>> valid serial# value. And if so, let's set it as g_dnl_serial value. >>> >>> Signed-off-by: Sam Protsenko <semen.protse...@linaro.org> >> >> Can't we use U_BOOT_ENV_CALLBACK() here instead and set the serial >> number when the environment variable is set ? > > Hmm... This might work. > > However, I'm a bit concerned with having "bound" the one particular env > variable ("serial#" in this case) to generic g_dnl.c code. That's a separate problem though, we already have this serial# variable in place.
-- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot