Hi,

On 08/31/2017 09:55 AM, Bin Meng wrote:
Hi Tuomas,

On Wed, Aug 30, 2017 at 4:31 PM, Tuomas Tynkkynen
<tuomas.tynkky...@iki.fi> wrote:
This board builds an U-Boot binary that is bootable with QEMU's 'virt'
machine on ARM. The minimal QEMU command line is:

     qemu-system-arm -machine virt,highmem=off -bios u-boot.bin

(Note that the 'highmem=off' parameter to the 'virt' machine is required for
PCI to work in U-Boot.) This command line enables the following:
     - u-boot.bin loaded and executing in the emulated flash at address 0x0
     - A generated device tree blob placed at the start of RAM
     - A freely configurable amount of RAM, described by the DTB
     - A PL011 serial port, discoverable via the DTB
     - An ARMv7 architected timer
     - PSCI for rebooting the system
     - A generic ECAM-based PCI host controller, discoverable via the DTB

Additionally, QEMU allows plugging a bunch of useful peripherals to the PCI bus.
The following ones are supported by both U-Boot and Linux:

- To enable a Serial ATA disk via an Intel ICH9 AHCI controller, pass e.g.:
     -drive if=none,file=disk.img,id=mydisk -device ich9-ahci,id=ahci -device 
ide-drive,drive=mydisk,bus=ahci.0
- To enable an Intel E1000 network adapter, pass e.g.:
     -net nic,model=e1000 -net user
- To add an EHCI-compliant USB host controller, pass e.g.:
     -device usb-ehci,id=ehci

Can we enable the NVMe driver (CONFIG_NVME) here?


Yes, 'nvme scan' and 'nvme list' it appear to work. I'll enable it.
There is a bunch of spew of this form though:

CACHE: Misaligned operation at range [bef5d000, bef5d020]



Signed-off-by: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi>
---
  arch/arm/Kconfig           | 10 ++++++++
  arch/arm/mach-qemu/Kconfig |  9 +++++++
  board/qemu-arm/Makefile    |  5 ++++
  board/qemu-arm/qemu-arm.c  | 35 ++++++++++++++++++++++++++
  configs/qemu_arm_defconfig | 27 ++++++++++++++++++++
  include/configs/qemu-arm.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++
  6 files changed, 149 insertions(+)
  create mode 100644 arch/arm/mach-qemu/Kconfig
  create mode 100644 board/qemu-arm/Makefile
  create mode 100644 board/qemu-arm/qemu-arm.c
  create mode 100644 configs/qemu_arm_defconfig
  create mode 100644 include/configs/qemu-arm.h

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 53d0831935..0d01ba1b73 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -630,6 +630,14 @@ config ARCH_MX5
         select CPU_V7
         select BOARD_EARLY_INIT_F

+config ARCH_QEMU
+       bool "QEMU Virtual Platform"
+       select CPU_V7
+       select ARCH_SUPPORT_PSCI
+       select DM
+       select DM_SERIAL
+       select OF_CONTROL
+
  config ARCH_RMOBILE
         bool "Renesas ARM SoCs"
         select DM
@@ -1149,6 +1157,8 @@ source "arch/arm/mach-stm32/Kconfig"

  source "arch/arm/mach-sunxi/Kconfig"

+source "arch/arm/mach-qemu/Kconfig"
+

Can you insert this by following alphabetical order?


Oops, yes of course.

  source "arch/arm/mach-tegra/Kconfig"

  source "arch/arm/mach-uniphier/Kconfig"
diff --git a/arch/arm/mach-qemu/Kconfig b/arch/arm/mach-qemu/Kconfig
new file mode 100644
index 0000000000..89d2a36719
--- /dev/null
+++ b/arch/arm/mach-qemu/Kconfig
@@ -0,0 +1,9 @@
+if ARCH_QEMU
+
+config SYS_BOARD
+       default "qemu-arm"
+
+config SYS_CONFIG_NAME
+       default "qemu-arm"
+
+endif
diff --git a/board/qemu-arm/Makefile b/board/qemu-arm/Makefile
new file mode 100644
index 0000000000..3e9907d983
--- /dev/null
+++ b/board/qemu-arm/Makefile

Can this new board be put into the board/emulation/qemu-arm directory?
Since qemu-x86 is put there.


Sure. There is still qemu-mips directly under board/ though.

@@ -0,0 +1,5 @@
+#
+# SPDX-License-Identifier:     GPL-2.0
+#
+
+obj-y  += qemu-arm.o
diff --git a/board/qemu-arm/qemu-arm.c b/board/qemu-arm/qemu-arm.c
new file mode 100644
index 0000000000..90d7badbf4
--- /dev/null
+++ b/board/qemu-arm/qemu-arm.c
@@ -0,0 +1,35 @@
+/*
+ * Copyright (c) 2017 Tuomas Tynkkynen
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+#include <common.h>
+#include <fdtdec.h>
+
+DECLARE_GLOBAL_DATA_PTR;

This is not needed as gd is not referenced in this file.


Now removed.

Thank you for the review.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to