On Sun, Sep 17, 2017 at 3:30 PM, Simon Glass <s...@chromium.org> wrote: > Hi Rob, > > On 17 September 2017 at 13:26, Rob Clark <robdcl...@gmail.com> wrote: >> On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass <s...@chromium.org> wrote: >>> On 13 September 2017 at 16:12, Rob Clark <robdcl...@gmail.com> wrote: >>>> Really just the subset that is needed by efi_console. Perhaps more will >>>> be added later, for example color support would be useful to implement >>>> efi_cout_set_attribute(). >>>> >>>> Signed-off-by: Rob Clark <robdcl...@gmail.com> >>>> --- >>>> drivers/video/Kconfig | 8 +++ >>>> drivers/video/vidconsole-uclass.c | 109 >>>> ++++++++++++++++++++++++++++++++++++++ >>>> drivers/video/video-uclass.c | 4 +- >>>> include/video.h | 7 +++ >>>> include/video_console.h | 11 ++++ >>>> 5 files changed, 136 insertions(+), 3 deletions(-) >>> >>> Reviewed-by: Simon Glass <s...@chromium.org> >>> >>> I don't see the test though - is that in another patch? >> >> well, at this point test is load/bootefi Shell.efi and does it look >> messed up on screen. If you have better ideas, let me know. > > It should be easy enough to update test/dm/video.o to use the new > feature in a new test. This code has nothing to do with EFI really. > > The tests are fairly slow in that they gzip the display to check that > it is correctly, but they work. >
ok, I guess snapshotting fb and comparing to a reference is a way.. where do I look to figure out how to build/run these tests (and presumable update reference screenshots?) I'd be inclined to add any test as a patch on top of the following patch to cover color escape sequences at the same time.. BR, -R _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot