Dear Kevin, in message <4b2796b7.3000...@fearnside-systems.co.uk> you wrote: > > All I really wanted to do was change the sc324x0 register struct members > to lower case, but if I do that without cleaning up the white space I > get checkpatch.pl errors, and if I don't change the code to use the > accessor functions the patch will get NAK-ed anyway...and all I really > want to do is get the code into a state where I can add support for the > Embest SBC244-II Board!
I understand and appreciate your efforts. In such a situation it is actually not really important in which order the changes are performend, but they shouldbe separated into orthogonal patches, and these patches submitted as a series. > I think I'll split the patches into a white-space change followed by an > accessor function/s3c24x0 register change patch. This is indeed the optimal sequence in this situation. > > Please also re-check the resulting code. I think there are some way > > too long lines, etc. > > checkpatch.pl didn't report any line length errors before I emailed the > patches. I'll check it again. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Humans do claim a great deal for that particular emotion (love). -- Spock, "The Lights of Zetar", stardate 5725.6 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot