Dear Vipin KUMAR, In message <1260955110-5656-8-git-send-email-vipin.ku...@st.com> you wrote: > > Signed-off-by: Vipin <vipin.ku...@st.com> > --- > MAKEALL | 1 + > Makefile | 3 + > board/spear/spear310/Makefile | 52 +++++ > board/spear/spear310/config.mk | 42 ++++ > board/spear/spear310/spr310_board.c | 58 ++++++ > include/configs/spear310.h | 353 > +++++++++++++++++++++++++++++++++++
The commit message seems wrong. You just add a new board, not a new SoC. > diff --git a/board/spear/spear310/config.mk b/board/spear/spear310/config.mk > new file mode 100755 > index 0000000..8b7aa05 > --- /dev/null > +++ b/board/spear/spear310/config.mk ... > +ifeq ($(CONSOLE),USB) > +PLATFORM_RELFLAGS += -DCONFIG_SPEAR_USBTTY > +endif > + No trailing empty lines, please. > +int board_nand_init(struct nand_chip *nand) > +{ > + struct misc_regs *const misc_regs_p = > + (struct misc_regs *)CONFIG_SPEAR_MISCBASE; > + > + if (((readl(&misc_regs_p->auto_cfg_reg) & MISC_SOCCFGMSK) == > + MISC_SOCCFG30) || > + ((readl(&misc_regs_p->auto_cfg_reg) & MISC_SOCCFGMSK) == > + MISC_SOCCFG31)) { > + > + return spear_nand_init(nand); > + } else { > + return -1; > + } No else, unindent the "return -1;". > +/* > + * Ethernet MAC driver configuration > + */ > +/* #define CONFIG_SPEAR_SMII */ > +/* #define CONFIG_SPEARMAC */ > +/* #define CONFIG_ETHAUTONEG */ > +/* #define CONFIG_ETHDEBUG */ Don't add dead code (fix globally). > + > +#define CONFIG_SYS_SERIAL1 0xB2000000 > +#define CONFIG_SYS_SERIAL2 0xB2080000 > +#define CONFIG_SYS_SERIAL3 0xB2100000 > +#define CONFIG_SYS_SERIAL4 0xB2180000 > +#define CONFIG_SYS_SERIAL5 0xB2200000 > +#define CONFIG_PL01x_PORTS { (void > *)CONFIG_SYS_SERIAL0, \ > + (void *)CONFIG_SYS_SERIAL1, \ > + (void *)CONFIG_SYS_SERIAL2, \ > + (void *)CONFIG_SYS_SERIAL3, \ > + (void *)CONFIG_SYS_SERIAL4, \ > + (void *)CONFIG_SYS_SERIAL5} Indentation / avertical alignment by TABs, please. [Globally.] > +#define CONFIG_BOOTARGS "console=ttyS0 mem=128M > " \ ... > +#define CONFIG_ENV_ADDR > (CONFIG_SYS_MONITOR_BASE + \ etc.: Lines too long. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The explanation requiring the fewest assumptions is the most likely to be correct. -- William of Occam _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot