Spam detection software, running on the system "lists.denx.de",
has identified this incoming email as possible spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Hi Philipp, å¨ 2017/10/6 18:17, Philipp Tomsich åé: >>
+Â Â Â if (pdata->clk_in) { >> +Â Â Â Â Â Â Â /* >> +Â Â Â Â Â Â Â Â * Since
mac_clk is fed by an external clock >> +Â Â Â Â Â Â Â Â * we can use 0 here.
>> +Â Â Â Â Â Â Â Â */ >> +Â Â Â Â Â Â Â ret = clk_set_rate(&clk, 0); > >
In hindsight using '0' was a bad decision. > We should always request the
expected external clock rate here (so the > clock driver could do some sanity
checking). [...]
Content analysis details: (6.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL
[211.157.147.133 listed in psbl.surriel.com]
0.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server
[58.22.7.114 listed in dnsbl.sorbs.net]
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net
[Blocked - see <http://www.spamcop.net/bl.shtml?58.22.7.114>]
2.4 RCVD_IN_MSPIKE_L5 RBL: Very bad reputation (-5)
[211.157.147.133 listed in bl.mailspike.net]
0.0 RCVD_IN_MSPIKE_BL Mailspike blacklisted
--- Begin Message ---
Hi Philipp,
在 2017/10/6 18:17, Philipp Tomsich 写道:
+ if (pdata->clk_in) {
+ /*
+ * Since mac_clk is fed by an external clock
+ * we can use 0 here.
+ */
+ ret = clk_set_rate(&clk, 0);
In hindsight using '0' was a bad decision.
We should always request the expected external clock rate here (so the
clock driver could do some sanity checking).
We need to tell CLK driver to configure internal or external register,
so do you think we're going to set this cru register directly in the
GAMC drive, or is it similar to kernel, introducing parent, CLK driver
through the parent to judge external or internal?
--- End Message ---
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
