Hi Marek, > -----Original Message----- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: Monday, October 30, 2017 6:55 PM > To: Ran Wang <ran.wan...@nxp.com> > Cc: bmeng...@gmail.com > Subject: Re: About the way to fix platform specific issue in source file > xhci.c > (U-Boot) > > On 10/30/2017 09:39 AM, Ran Wang wrote: > > Hi Vasut, > > For git://git.denx.de/u-boot-usb.git, I work out a patch to fix USB issue > which will happen on SoC LS2080A only (it's using DWC3). > > Per my understanding, we should not use platform define in xhci.c to > control its effect. However, I am not sure how to do it that can be accepted > by upstream, so send you this mail for suggestion before I post the patch to > patchwork. Thank you in advance. > > This should be fixed in common code, not in drivers.
Did you mean it should be fixed in common/usb*.c rather than drivers/usb/*? If yes, is it acceptable that I use 'if defined(CONFIG_ARCH_LS2080A)' in common/usb.c? If answer is no, how should I do? I cannot find an example and not sure it's OK to related rule. Another question: what's the rule to put fix in common/usb* or drivers/usb/*? >Also, such questions should be sent to the ML, not privately. > Got it. BR Ran > > > > > -- > Best regards, > Marek Vasut
0001-usb-Add-delay-to-fix-USB-2.0-stick-enumeration-failu.patch
Description: 0001-usb-Add-delay-to-fix-USB-2.0-stick-enumeration-failu.patch
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
