On Tue, Nov 28, 2017 at 05:14:58PM +0000, York Sun wrote: >On 11/27/2017 07:20 PM, Peng Fan wrote: >> For external data, FIT has a optional property "data-position" which >> can set the external data to a fixed offset to FIT beginning. >> Add the support for this property in SPL FIT. >> >> Signed-off-by: Ye Li <ye...@nxp.com> >> Signed-off-by: Peng Fan <peng....@nxp.com> >> Cc: Simon Glass <s...@chromium.org> >> Cc: Pantelis Antoniou <pantelis.anton...@konsulko.com> >> Cc: "Andrew F. Davis" <a...@ti.com> >> Cc: Igor Grinberg <grinb...@compulab.co.il> >> Cc: "tomas.me...@vaisala.com" <tomas.me...@vaisala.com> >> Cc: Kever Yang <kever.y...@rock-chips.com> >> Cc: Andre Przywara <andre.przyw...@arm.com> >> Cc: York Sun <york....@nxp.com> >> Cc: Lokesh Vutla <lokeshvu...@ti.com> >> Cc: "Cooper Jr., Franklin" <fcoo...@ti.com> >> Cc: George McCollister <george.mccollis...@gmail.com> >> Cc: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> >> Cc: Jean-Jacques Hiblot <jjhib...@ti.com> >> Cc: Rick Altherr <ralth...@google.com> >> Cc: Tom Rini <tr...@konsulko.com> >> --- >> common/image-fit.c | 25 +++++++++++++++++++++++++ >> common/spl/spl_fit.c | 11 +++++++++-- >> include/image.h | 3 +++ >> 3 files changed, 37 insertions(+), 2 deletions(-) > > >Looks good. Would it be appropriate to update >doc/uImage.FIT/source_file_format.txt to include this property?
All, Is the following explaination ok? diff --git a/doc/uImage.FIT/source_file_format.txt b/doc/uImage.FIT/source_file_format.txt index 6f727a1e8a..0db23db6c7 100644 --- a/doc/uImage.FIT/source_file_format.txt +++ b/doc/uImage.FIT/source_file_format.txt @@ -288,7 +288,8 @@ In this case the 'data' property is omitted. Instead you can use: The 'data-offset' property can be substituted with 'data-position', which defines an absolute position or address as the offset. This is helpful when -booting U-Boot proper before performing relocation. +booting U-Boot proper before performing relocation. Pass `-p [offset]` to +mkimage to enable `data-position`. If it is ok, I'll add it into V2. Thanks, Peng. > >York > >_______________________________________________ >U-Boot mailing list >U-Boot@lists.denx.de >https://lists.denx.de/listinfo/u-boot -- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
