Hi Simon, Sorry for my late response. Please see my comments inline.
Thanks a lot. > -----Original Message----- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: 2017年11月25日 6:36 > To: Y.b. Lu <yangbo...@nxp.com> > Cc: u-boot@lists.denx.de; Jaehoon Chung <jh80.ch...@samsung.com>; Yinbo > Zhu <yinbo....@nxp.com>; Xiaobo Xie <xiaobo....@nxp.com> > Subject: Re: dm: mmc: fsl_esdhc: Drop mmc_init() call from fsl_esdhc_init() > > Hi, > > On 20 November 2017 at 23:11, Y.b. Lu <yangbo...@nxp.com> wrote: > > Hi Simon, > > > > > > > > I found your below patch just dropping mmc_create() for probe > > procedure of DM. > > > > Actually the description seemed to be not the things this patch did. > > > > > > > > dm: mmc: fsl_esdhc: Drop mmc_init() call from fsl_esdhc_init() > > > > > > > > Do you have any suggestion to fix it? > > > > mmc_create() will allocate mmc structure and the DM in fsl_esdhc also > > allocate mmc structure in fsl_esdhc_plat structure. > > > > Do we need to rework the mmc_create(), or move rest initialization of > > mmc_create() in to fsl_esdhc_probe() ? > > But mmc_create() is only used in legacy code, not with driver model. > > Why do you want to call it here? Does your board not use CONFIG_DM_MMC? [Y.b. Lu] As I understand, mmc_create() is used for mmc host driver in which CONFIG_BLK is not implemented. Currently ls1012ardb board is using DM but CONFIG_BLK isn’t implemented. So now it couldn’t be added into mmc device list in initialization, and mmc command warns no MMC device. > > > > > > > > > Thanks a lot. > > Regards, > Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
