Hi Heinrich, On 8 January 2018 at 13:57, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 01/08/2018 05:50 AM, Simon Glass wrote: >> >> Hi Heinrich, >> >> On 3 January 2018 at 08:23, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> >>> Allow to override CONFIG_BOOTCOMMAND in .config. >>> >>> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> >>> --- >>> include/configs/x86-common.h | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> >> This is a Chrome OS boot line. I think you should consider whether it >> should move into x86-chromebook.h or similar? Then you can just remove >> it from the common file. > > > I understand Chromebooks uses this boot line. > > theadorable-x86-common.h undefines CONFIG_BOOTCOMMAND anyway. > For qemu I need to override the value. > > What about all the other x86 boards? > They seem to have bootargs matching the CONFIG_BOOTCOMMAND. > > As they are not using distro boot, wouldn't removing the CONFIG_BOOTCOMMAND > default value create havoc? > As a downstream user I would not cherish such a change. > > I think it is safer to leave the default value where it is. > > Would you accept the patch as is?
Bin seems happy and I have no objection. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
