On Thu, Jan 11, 2018 at 09:12:04AM +0900, Jorgen Lundman wrote: > > > > I'm reluctant to just take this as-is. That's a lot of code changes in > > a single commit that was not posted (as far as I can see) to the mailing > > list. Can you break that down into a series of changes that can be > > reviewed and post that? Thanks! > > > > I received an email that ZFS U-boot booting was tricky to get to work, > since it required old pool version, and didn't work at all with big endian. > > When I first did ZFS, I took the GRUB sources in 2012. So this time around, > I collected the commits from 2012 to now, and merged them into u-boot. Some > ~50 commits or so. It makes U-boot work with modern pools, and current > default compression (lz4) as well as raidz/mirror boots. > > It is a large change, I agree. But I'm unsure how to split it into smaller > commits. It is mostly bring it up to current with its upstream. > > If it is preferred to post to the ML, I will do so - I thought "git pull" > was an alternate. Please advice,
OK, so I took a look at https://github.com/lundman/u-boot/commit/c2727e5004fe011d19156d728babdf968515b28d and here's my comments: - You're missing the Signed-off-by line - You should mention the starting / ending revisions of your sync of the code from GRUB. - fs/zfs/zfs_lz4.c needs to use an SPDX tag. - You've got some changes that change the Copyright year from 2012 to 2018, when it should be 2012-2018 And finally, it's not so large that you can't post the patch to the ML for additional reviews and I'll pick it up and apply it directly. Thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot