Khasim Syed Mohammed wrote:
> From 15fbe5ff9ee2fd2f8da4c16805d6c7ccf7244bae Mon Sep 17 00:00:00 2001
> From: Syed Mohammed Khasim <kha...@ti.com>
> Date: Fri, 8 Jan 2010 20:13:47 +0530
> Subject: [PATCH] OMAP3 Beagle Update revision detection
> 
<snip>

>       MUX_BEAGLE();
> 
> -     if (beagle_revision_c) {
> +     if (beagle_revision != REVISION_AXBX)
>               MUX_BEAGLE_C();
> -     }

Because MUX_BEAGLE_C is a multiline macro,
it would be good to keep the '{ }'

>  }
> diff --git a/board/ti/beagle/beagle.h b/board/ti/beagle/beagle.h
> index 7fe6275..b1720c9 100644
> --- a/board/ti/beagle/beagle.h
> +++ b/board/ti/beagle/beagle.h
> @@ -33,7 +33,11 @@ const omap3_sysinfo sysinfo = {
>  #endif
>  };
> 
> -#define BOARD_REVISION_MASK  (0x1 << 11)
> +/* BeagleBoard revisions */
> +#define REVISION_AXBX        0x7
> +#define REVISION_CX  0x6
> +#define REVISION_C4  0x5
> +#define REVISION_D   0x0
> 
ws
remove spaces at the end of var's in the last 4 lines


Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to