On Tue, Jan 23, 2018 at 2:32 PM, Vignesh R <vigne...@ti.com> wrote: > > > On Tuesday 23 January 2018 02:15 PM, Jagan Teki wrote: >> On Tue, Jan 23, 2018 at 1:42 PM, Simon Goldschmidt >> <sgoldschm...@de.pepperl-fuchs.com> wrote: >>> Jagan, >>> >>> >>> the merge window is now less than 1 week for 2018.03 if I'm not mistaken. >>> Can you apply this, please? >> >> Can you resend these on-top of u-boot-spi/master, have few changes on >> wait_for_bit good to test those as well. > > u-boot-spi/master throws few warnings when I build for my platform: > ~/workspace/u-boot:0f520af57c60:~ make distclean;make k2g_evm_defconfig;make > -j4 -s; > > In file included from drivers/spi/cadence_qspi_apb.c:31:0: > include/wait_bit.h: In function 'wait_for_bit_be16': > include/wait_bit.h:76:31: warning: implicit declaration of function > 'readw_be' [-Wimplicit-function-declaration] > BUILD_WAIT_FOR_BIT(be16, u16, readw_be) > ^ > include/wait_bit.h:48:9: note: in definition of macro 'BUILD_WAIT_FOR_BIT' > val = read(reg); \ > ^~~~ > include/wait_bit.h: In function 'wait_for_bit_be32': > include/wait_bit.h:78:31: warning: implicit declaration of function > 'readl_be' [-Wimplicit-function-declaration] > BUILD_WAIT_FOR_BIT(be32, u32, readl_be) > ^ > include/wait_bit.h:48:9: note: in definition of macro 'BUILD_WAIT_FOR_BIT' > val = read(reg); \ > ^~~~
Did you change wait_for_bit function with _le32? [1] [1] http://git.denx.de/?p=u-boot-spi.git;a=commitdiff;h=9a5ff2669ef185d3a4bf73415c531e8d013993d8 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
