On Mon, Jan 29, 2018 at 01:44:53PM +0530, Jagan Teki wrote: > On Mon, Jan 29, 2018 at 1:29 PM, Maxime Ripard > <maxime.rip...@free-electrons.com> wrote: > > Hi, > > > > On Sun, Jan 28, 2018 at 09:49:29PM +0530, Jagan Teki wrote: > >> PHYCTL register offset at 0x10 need to be cleared before it's > >> written. Ported from below Linux patch. > >> d699c1d phy: sun4i-usb: change PHYCTL register clearing code > >> > >> Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> > >> Signed-off-by: Jun Nie <jun....@linaro.org> > > > > Those signed-off-by don't make much sense. Either Jun made that patch > > and should be the author, or you made that patch, and Jun Signed-off > > shouldn't be there. > > Don't understand what doesn't make sense, more Signed-off-by implies > group of people worked on the particular change and author who usually > made this. This is what I usually follow all my patches if the > change/patch work together.
Jun's Signed-off implies that he merged and carried this patch, ie Jun was acting as a maintainer, or was sending a patch on behalf of you. This isn't the case. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
