On 6 February 2018 at 13:12, Tom Rini <tr...@konsulko.com> wrote: > On Tue, Feb 06, 2018 at 10:31:10AM +1100, Bin Chen wrote: > > > Hello Tom, > > > > Any feedback on this? > > It's on my list to grab soon, thanks! > > Excellent! Thanks!
> > > > On 27 January 2018 at 16:59, Bin Chen <bin.c...@linaro.org> wrote: > > > > > > > > I rebased the two patches submitted (quite )a while ago on top of > > > current U-boot master fb4413295c765aa8c013650984dc2d908964c81d > > > (and there were no conflicts). > > > > > > The first patch added the support of parsing the second area of Android > > > image so > > > that it can be used for good. On Poplar board, we are using that area > for > > > dtb. > > > The first patch shouldn't impact any functionality since > > > it is new. > > > > > > The second patch moves the booti_setup out of booti.c. It was the > result > > > of a > > > discusion[1] how to better support the arm64 Android image. > > > > > > I have boot tested it on Poplar board[2] with additional patch[3] that > is > > > built on top of the booti. I have hacked version of using bootm but it > > > seems quit > > > mess up - need lots of changes in different places ("Shotgun Surgery") > to > > > handle > > > Android specific and/or arm64 specific code. Now, I feel a separate > > > bootandroid command might be a cleaner solution. > > > > > > That being said, the second patch doesn't depend on or impact any > change we > > > might have in the future for better Android support. > > > > > > [1] https://lists.denx.de/pipermail/u-boot/2017-July/297933.html > > > [2] https://github.com/96boards-poplar/Documentation > > > [3] https://github.com/pierrchen/u-boot/commit/ > > > 8463e6177654026746161487d0f0bd8998bb7a5b > > > > > > Bin Chen (2): > > > parse the second area of android image > > > move booti_setup to arch/arm/lig/image.c > > > > > > arch/arm/lib/Makefile | 2 +- > > > arch/arm/lib/image.c | 76 +++++++++++++++++++++++++++++++++++++++++ > > > cmd/booti.c | 92 +++++++----------------------- > > > -------------------- > > > common/image-android.c | 19 +++++++++++ > > > include/image.h | 11 ++++++ > > > 5 files changed, 120 insertions(+), 80 deletions(-) > > > create mode 100644 arch/arm/lib/image.c > > > > > > -- > > > 2.15.0 > > > > > > > > > > > > -- > > Regards, > > Bin > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > -- > Tom > -- Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot