Hi Lokesh, On 6.2.2018 13:28, Michal Simek wrote: > There is no reason to unconditially select network commands as distro > defaults without networking enable. > > Signed-off-by: Michal Simek <michal.si...@xilinx.com> > --- > > Changes in v2: > - Use if NET instead of imply (suggested by Tom) > - Change patch subject and description > > Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Kconfig b/Kconfig > index f713c6a9b188..166e7841b11f 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -69,14 +69,14 @@ config DISTRO_DEFAULTS > imply USE_BOOTCOMMAND > select CMD_BOOTZ if ARM && !ARM64 > select CMD_BOOTI if ARM64 > - select CMD_DHCP > - select CMD_PXE > + select CMD_DHCP if NET > + select CMD_PXE if NET > select CMD_EXT2 > select CMD_EXT4 > select CMD_FAT > select CMD_FS_GENERIC > - select CMD_MII > - select CMD_PING > + select CMD_MII if NET > + select CMD_PING if NET > select CMD_PART > select HUSH_PARSER > help >
Based on https://travis-ci.org/michalsimek/u-boot/jobs/338051973 Lokesh: There is an issue with omap4_sdp4430_defconfig where CONFIG_NET is not enabled but PXE and DHCP configs are present. This is quite weird and IMHO CONFIG_NET should be enabled for this target. This can be one resolution. diff --git a/configs/omap4_sdp4430_defconfig b/configs/omap4_sdp4430_defconfig index ac495710633c..59526fd1dc35 100644 --- a/configs/omap4_sdp4430_defconfig +++ b/configs/omap4_sdp4430_defconfig @@ -23,7 +23,10 @@ CONFIG_CMD_SPI=y # CONFIG_CMD_NET is not set # CONFIG_CMD_NFS is not set CONFIG_CMD_EXT4_WRITE=y +# CONFIG_EFI_PARTITION is not set +CONFIG_SPL_PARTITION_UUIDS=y CONFIG_ENV_IS_IN_MMC=y +CONFIG_NET=y CONFIG_MMC_OMAP_HS=y CONFIG_SYS_NS16550=y CONFIG_OMAP3_SPI=y @@ -31,4 +34,6 @@ CONFIG_USB=y CONFIG_USB_MUSB_UDC=y CONFIG_USB_OMAP3=y CONFIG_FAT_WRITE=y +# CONFIG_REGEX is not set CONFIG_OF_LIBFDT=y +# CONFIG_EFI_LOADER is not set Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
