On Thu, 1970-01-01 at 00:00 +0000, Maxime Ripard wrote: > Hi, > > On Tue, Feb 06, 2018 at 08:20:49AM +0000, Joakim Tjernlund wrote: > > On Thu, 1970-01-01 at 00:00 +0000, Simon Goldschmidt wrote: > > > > ..... > > > > Reviewed-by: Andre Przywara <andre.przyw...@arm.com> > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> > > > > --- > > > > env/env.c | 80 > > > > +++++++++++++++++++++++++++++++++++--------------------- > > > > 1 file changed, 50 insertions(+), 30 deletions(-) > > > > > > > > diff --git a/env/env.c b/env/env.c > > > > index 906f28ee50a1..1182fdb545db 100644 > > > > --- a/env/env.c > > > > +++ b/env/env.c > > > > @@ -26,6 +26,41 @@ static struct env_driver *_env_driver_lookup(enum > > > > env_location loc) > > > > return NULL; > > > > } > > > > > > > > +static enum env_location env_locations[] = { > > > > Don't use static/global variables. They cause a lot of relocation work/size > > and is less flexible. There is no way to #define ENVL_EEPROM to a function > > when a variable. > > Is that last sentence truncated? > > Can you elaborate a bit more on what is the source of the relocation > issues you're mentionning? Is that because of the section it ends up > in?
Mainly that its adds relocation entries that take up space, more space than doing a simple assignment directly in code. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot