[U-Boot] [PATCH 1/1] regulator: pbias: don't evaluate variable before assignment

[Heinrich Schuchardt]

We should not evaluate the value of reg before its value is set.

Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---
 drivers/power/regulator/pbias_regulator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/regulator/pbias_regulator.c 
b/drivers/power/regulator/pbias_regulator.c
index 116b7f480a..adf589b224 100644
--- a/drivers/power/regulator/pbias_regulator.c
+++ b/drivers/power/regulator/pbias_regulator.c
@@ -225,9 +225,6 @@ static int pbias_regulator_set_value(struct udevice *dev, 
int uV)
        int rc;
        u32 reg;
 
-       debug("Setting %s voltage to %s\n", p->name,
-             (reg & p->vmode) ? "3.0v" : "1.8v");
-
        rc = pmic_read(dev->parent, 0, (uint8_t *)&reg, sizeof(reg));
        if (rc)
                return rc;
@@ -239,6 +236,9 @@ static int pbias_regulator_set_value(struct udevice *dev, 
int uV)
        else
                return -EINVAL;
 
+       debug("Setting %s voltage to %s\n", p->name,
+             (reg & p->vmode) ? "3.0v" : "1.8v");
+
        return pmic_write(dev->parent, 0, (uint8_t *)&reg, sizeof(reg));
 }
 
-- 
2.16.2

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot