On Wed, Jan 24, 2018 at 10:55:59AM +0100, Rasmus Villemoes wrote: > It is sometimes useful to be able to define the entire default > environment in an external file. This implements a Kconfig option for > allowing that. > > It is somewhat annoying to have two visible Kconfig options; it would > probably be more user-friendly to just have the string option (with > empty string obviously meaning not to use this feature). But then we'd > also need a hidden CONFIG that we can use in the #ifdef in > env_default.h, and I don't think one can set a def_bool based on > whether a string-valued config is empty or not. > > I've tried to make the accepted format the same as the one the > mkenvimage tool accepts. I have no idea how portable the sed script > implementing the "allow embedded newlines in values" is. Nor do I know > if one can expect xxd to be available. > > Signed-off-by: Rasmus Villemoes <rasmus.villem...@prevas.dk> > --- > Makefile | 16 ++++++++++++++++ > env/Kconfig | 18 ++++++++++++++++++ > include/env_default.h | 4 ++++ > 3 files changed, 38 insertions(+)
Conceptually, this is fine. But can you please re-word the commit message and put some of the commentary below the --- ? Also, in general we do a pair of CONFIG_USE_xxx and CONFIG_xxx, so you might need to re-word the rest of the option name a bit too to match that. Thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot