Hi Klaus,

On 18 March 2018 at 11:35, Klaus Goger
<klaus.go...@theobroma-systems.com> wrote:
> Adds devicemodel support to the ISL1208 driver.
> This patch drops the non-dm API as no board was using it anyway.
> Also add it to Kconfig.
>
> Signed-off-by: Klaus Goger <klaus.go...@theobroma-systems.com>
>
> ---
>
>  drivers/rtc/Kconfig   |   7 +++
>  drivers/rtc/isl1208.c | 141 
> ++++++++++++++++++++++++++++++--------------------
>  2 files changed, 93 insertions(+), 55 deletions(-)

Reviewed-by: Simon Glass <s...@chromium.org>

Please see below

>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 95ac031243..960c3fc3e2 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -30,6 +30,13 @@ config RTC_DS1307
>           Support for Dallas Semiconductor (now Maxim) DS1307 and DS1338/9 and
>           compatible Real Time Clock devices.

It would be nice to add a few more details here, like if it supports
battery-backed storage, or any other notable features (and what
hardware features the driver does and does not support).

Regards
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to