On 03/20/2018 02:36 AM, Bin Meng wrote: > Hi Marek, > > On Mon, Mar 19, 2018 at 5:42 PM, Marek Vasut <ma...@denx.de> wrote: >> On 03/19/2018 04:17 AM, Bin Meng wrote: >>> Hi Marek, >>> >>> The following changes since commit 958ad42b77be9d9a69f059066622ef0c15c603ee: >>> >>> usb: dwc2: Replace printf, pr_err by dev_info, dev_err (2018-03-19 >>> 11:03:46 +0800) >>> >>> are available in the git repository at: >>> >>> git://git.denx.de/u-boot-usb.git topic-xhci >>> >>> for you to fetch changes up to 24b36b94c661ddbcb8d211a33ed4055178208211: >>> >>> usb: xhci: remove superfluous assignment (2018-03-19 11:09:10 +0800) >>> >>> ---------------------------------------------------------------- >>> Heinrich Schuchardt (4): >>> usb: xhci-exynos5: correct error checking >>> usb: xhci-keystone: remove superfluous assignment >>> usb: xhci-ring: remove superfluous assignment >>> usb: xhci: remove superfluous assignment >>> >>> drivers/usb/host/xhci-exynos5.c | 2 +- >>> drivers/usb/host/xhci-keystone.c | 4 ++-- >>> drivers/usb/host/xhci-ring.c | 2 +- >>> drivers/usb/host/xhci.c | 4 ++-- >> >> I believe all of those patches were completely untested and should first >> be applied to Linux and then backported, so I won't take this PR. > > Why do we require U-Boot driver fixes to be firstly applied to Linux, > then backported? Some of them was ported from Linux before, but as > time goes I don't think they are a 100% match now.
That's even worse, since that makes it impossible to backport fixes from Linux. > Besides, these 4 fixes are really obvious. Yes, but then they should be fixed in Linux first and backported to U-Boot , since the whole xhci stack is taken from Linux, right ? -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot