On Tue, 27 Mar 2018, Kever Yang wrote:
boot_devices may defined in soc file, and used in board file,
we need to delear it in header file.
I think you meant to write 'declare'.
Again: a bit more context from the commit message might be useful (e.g.
what is 'boot_devices'?
If 'boot_devices' suddenly becomes visible across multiple files, we may
need to rethink its naming... 'boot_devices' is too similar to names used
in SPL (e.g. 'boot_device') and could easily be confused.
Signed-off-by: Kever Yang <kever.y...@rock-chips.com>
See below for requested changes.
---
arch/arm/include/asm/arch-rockchip/bootrom.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/arch-rockchip/bootrom.h
b/arch/arm/include/asm/arch-rockchip/bootrom.h
index 103b799..ac2f370 100644
--- a/arch/arm/include/asm/arch-rockchip/bootrom.h
+++ b/arch/arm/include/asm/arch-rockchip/bootrom.h
@@ -53,6 +53,8 @@ enum {
BROM_LAST_BOOTSOURCE = BROM_BOOTSOURCE_USB
};
+extern const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1];
If you make this visible outside of a single board file and move it to a
header file, this needs some documentation (and naming will need to be
rethought as well, as described above).
+
/**
* Locations of the boot-device identifier in SRAM
*/
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
