Hi Neil, On 4 April 2018 at 04:45, Neil Armstrong <narmstr...@baylibre.com> wrote: > On 03/04/2018 19:53, Simon Glass wrote: >> On 3 April 2018 at 17:40, Neil Armstrong <narmstr...@baylibre.com> wrote: >>> This patch adds the bulk reset API tests for the sandbox test suite. >>> >>> Unlike the main test, it also check the "other" reset signal using the bulk >>> API >>> and checks if the resets are correctly asserted/deasserted. >>> >>> To allow the bulk API to work, and avoid changing the DT, the number of >>> resets >>> of the sandbox reset controller has been bumped to 101 for the "other" reset >>> line to be valid. >> >> Does it need to be 101, or would, say, 5 be enough? > > It could stay at 3, but a dts change should be needed since it declares : > > resets = <&resetc 100>, <&resetc 2>; > reset-names = "other", "test";
Well that is fine if you want to change test.dts - you just need to make sure you keep the intent. But you've explained the reason, and it's fine to keep this patch as is, if you like. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
