Hi Mario, On 18 April 2018 at 02:52, Mario Six <mario....@gdsys.cc> wrote: > Hi Simon, > > On Thu, Apr 12, 2018 at 6:38 PM, Simon Glass <s...@chromium.org> wrote: >> Hi Mario, >> >> On 11 April 2018 at 01:27, Mario Six <mario....@gdsys.cc> wrote: >>> Hi Simon, >>> >>> On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote: >>>> Hi Mario, >>>> >>>> On 28 March 2018 at 20:40, Mario Six <mario....@gdsys.cc> wrote: >>>>> Add a driver for the Xilinx LogiCORE DisplayPort IP core. >>>>> >>>>> Signed-off-by: Mario Six <mario....@gdsys.cc> >>>>> --- >>>>> drivers/video/Kconfig | 8 + >>>>> drivers/video/Makefile | 1 + >>>>> drivers/video/logicore_dp_dpcd.h | 342 ++++++ >>>>> drivers/video/logicore_dp_tx.c | 1974 ++++++++++++++++++++++++++++++++++ >>>>> drivers/video/logicore_dp_tx.h | 40 + >>>>> drivers/video/logicore_dp_tx_regif.h | 365 +++++++ >>>>> 6 files changed, 2730 insertions(+) >>>>> create mode 100644 drivers/video/logicore_dp_dpcd.h >>>>> create mode 100644 drivers/video/logicore_dp_tx.c >>>>> create mode 100644 drivers/video/logicore_dp_tx.h >>>>> create mode 100644 drivers/video/logicore_dp_tx_regif.h >>>> >>>> Is it possible to have common code with the other DP drivers? >>>> >>> >>> While the DP transmitters, of course, all do similar things (e.g. they all >>> eventually set a lane count), the implementation details differ greatly, and I >>> think trying to merge them would only make things more confusing, since the >>> drivers tend to be pretty elaborate (looking at the exynos driver, for >>> example). >> >> OK. Are they merged in Linux? >> > > The Linux DP drivers don't share a common code base either (grepping > "lane_count" in drivers/gpu shows different implementations of lane setting and > link training).
OK, well that is suggestive. Perhaps duplicating the code is best. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot